Open
Conversation
dracos
reviewed
Mar 4, 2026
Member
dracos
left a comment
dracos
left a comment
There was a problem hiding this comment.
One query is all :)
(And translation of the cy email templates which I know you know)
| my $ret = undef; | ||
| if (my $msg = dbh()->selectrow_hashref("select * from message where group_id = ?", {}, $group_id)){ | ||
| throw FYR::Error("You've already sent these messages, there's no need to send them twice.", FYR::Error::GROUP_ALREADY_QUEUED); | ||
| throw FYR::Error(_("You've already sent these messages, there's no need to send them twice."), FYR::Error::GROUP_ALREADY_QUEUED); |
Member
There was a problem hiding this comment.
Are these messages shown, or are they just logged for us somewhere?
Just wondering if this commit isn't needed, wasn't sure.
Member
Author
There was a problem hiding this comment.
There's definitely bits where $error->text is displayed to the user even is a lot of them are handled by using the code so seemed safest to translate them all.
struan
force-pushed
the
518-language-aware-messages
branch
from
87d6d09 to
f9ebc08
Compare
Just enough Welsh to use in a test
struan
force-pushed
the
518-back-end-translations
branch
from
220db89 to
2c9c8a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap strings in Queue etc in gettet plus add in templates for translating to Welsh.
This includes some translations for the purposes of testing which will need someone to confirm. Note that once full translations are in some of the tests will require updating. The current tests do enough to check everything works but are not complete.
Fixes #519